-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Replace addr
with ref
in design docs
#6141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace addr
with ref
in design docs
#6141
Conversation
Oh, also apologies for any merge conflicts this may cause to in-progress work! I checked that my changes were the same or similar to the ones mentioned in #6032, so conflicts should be minimal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you sync to head and resolve the merge conflicts?
Replaced mechanically. Care is taken to preserve `const` and remove the `*` from the type. This also removes `->` uses of `self` and replaces them with `.`, using the same mechanical tools.
These functions used to refer to the `addr` keyword in their names.
ef94cba
to
56f64a5
Compare
Sorry about the delay, just got back from a summit. I rebased cleanly without any new changes 😄 |
Thanks for cleaning this up! |
Updates the documentation under
docs/design/
to useref
instead ofaddr
after their removal in #5434. Care was taken to manually clean up edge cases and, in a couple cases, surrounding text (see 3d72c49). After this change, there are no matches foraddr(?!ess)
indocs/design/
.Closes #6032