Skip to content

Conversation

clavin
Copy link
Contributor

@clavin clavin commented Sep 27, 2025

Updates the documentation under docs/design/ to use ref instead of addr after their removal in #5434. Care was taken to manually clean up edge cases and, in a couple cases, surrounding text (see 3d72c49). After this change, there are no matches for addr(?!ess) in docs/design/.

Closes #6032

@github-actions github-actions bot added the documentation An issue or proposed change to our documentation label Sep 27, 2025
@github-actions github-actions bot requested a review from zygoloid September 27, 2025 05:16
@clavin
Copy link
Contributor Author

clavin commented Sep 27, 2025

Oh, also apologies for any merge conflicts this may cause to in-progress work! I checked that my changes were the same or similar to the ones mentioned in #6032, so conflicts should be minimal.

Copy link
Contributor

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@geoffromer geoffromer self-requested a review September 30, 2025 16:49
Copy link
Contributor

@geoffromer geoffromer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sync to head and resolve the merge conflicts?

clavin added 6 commits October 4, 2025 10:16
Replaced mechanically. Care is taken to preserve `const` and remove the `*` from the type. This also removes `->` uses of `self` and replaces them with `.`, using the same mechanical tools.
These functions used to refer to the `addr` keyword in their names.
@clavin clavin force-pushed the clavin/rename-addr-to-ref branch from ef94cba to 56f64a5 Compare October 4, 2025 16:16
@clavin clavin requested a review from a team as a code owner October 4, 2025 16:16
@clavin clavin requested review from danakj and removed request for a team October 4, 2025 16:16
@clavin
Copy link
Contributor Author

clavin commented Oct 4, 2025

Sorry about the delay, just got back from a summit. I rebased cleanly without any new changes 😄

@danakj danakj removed their request for review October 6, 2025 14:05
@geoffromer geoffromer enabled auto-merge October 6, 2025 18:34
@geoffromer geoffromer added this pull request to the merge queue Oct 6, 2025
Merged via the queue into carbon-language:trunk with commit bd4d580 Oct 6, 2025
8 checks passed
@geoffromer
Copy link
Contributor

Thanks for cleaning this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation An issue or proposed change to our documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up addr in docs

3 participants